Skip to content

Fix initial guess in collocation solvers - #460

Merged
ErikQQY merged 21 commits into
masterfrom
qqy/fix_initial_guess
Apr 3, 2026
Merged

Fix initial guess in collocation solvers#460
ErikQQY merged 21 commits into
masterfrom
qqy/fix_initial_guess

Conversation

@ErikQQY

@ErikQQY ErikQQY commented Mar 25, 2026

Copy link
Copy Markdown
Member

Fix: #457

@github-actions

github-actions Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmark Results

Click to check benchmark results
master f5d177c... master / f5d177c...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.583 ± 0.022 s 0.571 ± 0.0092 s 1.02 ± 0.043
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 12.4 ± 0.51 ms 12.2 ± 0.37 ms 1.01 ± 0.052
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 2.37 ± 0.17 ms 2.38 ± 0.11 ms 0.998 ± 0.084
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 2.9 ± 0.42 ms 2.89 ± 0.43 ms 1.01 ± 0.21
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.14 ± 0.22 ms 1.13 ± 0.21 ms 1.01 ± 0.27
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 2.55 ± 0.61 ms 2.57 ± 0.6 ms 0.992 ± 0.33
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 5.04 ± 1.1 ms 5.08 ± 1.1 ms 0.993 ± 0.29
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0694 ± 0.0078 s 0.071 ± 0.012 s 0.977 ± 0.2
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.103 ± 0.024 s 0.106 ± 0.021 s 0.974 ± 0.3
Simple Pendulum/IIP/Shooting(Tsit5()) 0.3 ± 0.084 ms 0.306 ± 0.083 ms 0.983 ± 0.38
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.73 ± 0.013 s 0.727 ± 0.0058 s 1 ± 0.02
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 15 ± 5.1 ms 15 ± 5.3 ms 0.997 ± 0.49
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 2.77 ± 0.13 ms 2.77 ± 0.14 ms 0.998 ± 0.068
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 3.44 ± 0.17 ms 3.4 ± 0.15 ms 1.01 ± 0.068
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.33 ± 0.11 ms 1.32 ± 0.1 ms 1.01 ± 0.11
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.55 ± 2.8 ms 3.53 ± 2.7 ms 1.01 ± 1.1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 7.06 ± 5.9 ms 7.04 ± 5.8 ms 1 ± 1.2
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0833 ± 0.0022 s 0.085 ± 0.0025 s 0.98 ± 0.039
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.129 ± 0.0044 s 0.132 ± 0.0061 s 0.982 ± 0.057
Simple Pendulum/OOP/Shooting(Tsit5()) 0.603 ± 0.047 ms 0.606 ± 0.042 ms 0.996 ± 0.1
time_to_load 7.29 ± 0.0074 s 7.28 ± 0.0026 s 1 ± 0.0011
### Benchmark Plots A plot of the benchmark results has been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@ErikQQY ErikQQY mentioned this pull request Mar 26, 2026
Closed
@ChrisRackauckas

ChrisRackauckas commented Mar 26, 2026

Copy link
Copy Markdown
Member

Can you add a test for this? Do something like setting maxiters = 0 and checking that the solution matches the initial guess.

@ErikQQY

ErikQQY commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

It's weird the CI for FIRK testing just stoped without any errors🤔

@ErikQQY
ErikQQY merged commit 2692074 into master Apr 3, 2026
25 of 27 checks passed
@ErikQQY
ErikQQY deleted the qqy/fix_initial_guess branch April 3, 2026 20:14
@JBMcVey JBMcVey mentioned this pull request Apr 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in initializing boundary conditions for FIRK BVP solvers

2 participants

@ErikQQY @ChrisRackauckas